Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default to dataplane being supported when checking version annotation #1731

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

ndhanushkodi
Copy link
Contributor

Changes proposed in this PR:

  • Default to consul-dataplane being supported even when the version annotation is malformed. If the version annotation exists, it already means we're running consul-k8s 1.0.0+.

Eric ran into this when using an image built from our pipeline that builds images from main. It has a version formatted like "v1.0.0-dev ()" which is not a recognized version by the client health checks code and causes endpoints controller to think that consul-dataplane is not supported and attempt to register client health checks which won't work.

We would have run into this with our released image as well since they are built the same way as the images from main. We did NOT run into this in acceptance tests because the images built for acceptance tests are built differently and do not have the () part.

In the future we will fix our pipelines to include versions that can be parsed by the go-version library, but talking to @ishustava, we don't want to do that so close to the release.

Checklist:

  • Tests added
    - [ ] CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ndhanushkodi ndhanushkodi merged commit a14f597 into main Nov 17, 2022
@ndhanushkodi ndhanushkodi deleted the nd/fix-upgrade-version-checks branch November 17, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants